Repository navigation
Migrate shared Identity.DirectoryManagement directives to v3 - #3902
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 16 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 16 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 16 commits into
Conversation
Review both compatible profiles against actual legacy selector lineages, preserve structural naming and deferred aliases, and pin exact suppression and rename boundaries. Reviewed Legacy bridge inventory validation requires central PR #3847. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document the zero same-module beta counterparts without inferring a root relocation or changing the independent Identity.SignIns policies lineage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full queued Release pipeline with Kiota 1.36.1 and the required compatible spec. Compiled manifest exports 595 cmdlets; migrated and neighboring routes are confirmed. Client code and project templates regenerate byte-identically; the client lock records the current Kiota version. Only the untyped deletedItems collection variant is removed from the existing public GET. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use separate runtime profile context with derived naming on and off, refresh complete original shared-directive selections and current literal evidence, and preserve incompatible action operations with meaningful body-backed distinct names. Current strict inventory passes ten mapped groups plus one deferred alias; 102 targeted regressions pass. Collection reference deletion still requires central required-query emission before publication. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run unchanged full four-mutex queued Release pipeline with isolated Kiota 1.36.1 and original official Authentication 2.38.1. Actual build exit0, module OK, 31.9 seconds, 597 exports; fresh compiled migrated and neighbor route checks pass. Preserve client+cmdlets+project/lock output in this profile boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run unchanged full four-mutex queued Release pipeline with isolated Kiota 1.36.1 and original official Authentication 2.38.1. Actual build exit0, module OK, 56.4 seconds, 963 exports; fresh compiled migrated and neighbor route checks pass. Preserve client+cmdlets+projects+locks in one beta commit. Publication remains blocked by central serialization packaging and required collection-reference @id query emission; successful compilation is not body/HTTP validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reprove the approved obsolete directory rollout removal against its independently pre-existing original and current Identity.SignIns neighbor; retain exact IDs without inventing a root translation. The combined current-target module/configurator/naming regressions remain 102 passing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…t revalidation Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Cover every surviving required native query from both actual compatible specs with derived data on and off, mandatory Query-prefixed input and native Kiota binding. v1.0 has no surviving required query after shared suppressions; beta preserves mandatory QueryId without an old Id alias. Current module/configurator/naming regressions execute 106 tests, all passing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run unchanged full four-mutex queued Release pipeline on normally merged target 4eb3ca3 with isolated Kiota 1.36.1 and hash-verified adapted Authentication 2.41.2. Build exit0, module OK, 50.1 seconds, 597 exports. All four original collection reference suppressions and no-query item neighbors remain intact; no surviving v1 required native query exists. Fresh normal-manifest and Global/USGov offline factory/body/session gates pass independently; bound generic headers on PATCH204 refetch remain an unwaived #3886 blocker. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run unchanged full four-mutex queued Release pipeline on normally merged target 4eb3ca3 with isolated Kiota 1.36.1 and hash-verified adapted Authentication 2.41.2. Build exit0, module OK, 89.2 seconds, 963 exports. The sole surviving required-query operation binds mandatory QueryId to exact encoded @id; all four shared collection suppressions and item-reference neighbors remain unchanged. Actual Global/USGov factory/binder/bodyless/header/ShouldProcess/query gates pass; PATCH204 generic-header refetch still fails #3886 and blocks publication. Kiota client and locks regenerate byte-identically. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Actual Contact and beta DirectorySetting PATCH sources bind their own body and headers, never issue implicit GET, and emit only a non-null actual response without adding a readback switch. Current module/configurator/naming/required-query regressions execute 178 tests, all passing. Historical refetch failure proof remains preserved as superseded evidence. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the unchanged full four-mutex queued Release pipeline on normally merged target6475f3f5 with isolated Kiota1.36.1 and hash-verified adapted Authentication2.41.2. Build exit0, moduleOK,651.2seconds,597exports. Fresh Global/USGov full-module proofs pass PATCH204 oneHTTP/nooutput/noGET, PATCH200 actual typedmodel, caller-explicitGET headers/select/error, required-query suppression/itemneighbors, safety/session/cloud/identity. Client and lock regeneration is byte-identical; preserve this combined profile boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the unchanged full four-mutex queued Release pipeline on normally merged target6475f3f5 with isolated Kiota1.36.1 and hash-verified adapted Authentication2.41.2. Build exit0, moduleOK,219.2seconds,963exports. Fresh Global/USGov fullmodule acceptance passes77checks percell, includingContact/DirectorySettingPATCH204 oneHTTP/nooutput/noGET,200typedmodel,callerexplicitGET,alltagactionbodies,mandatoryQueryId exactwire/binders/bodylessreferenceheaders,defaults/neighbors/Confirm/sessionidentity. Clients and locks regenerate byte-identically; preserve this combined profile boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
November 6, 2026 02:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A — module-specific v3 directive migration.
Changes proposed in this pull request
Identity.DirectoryManagement.mddirective groups: 10 reviewed mappings and one explicitly deferred alias group. Preserve the active source directives, full actual original operation-ID selector sets, both compatible-profile triples, and derived naming precedence. The untyped deleted-item list/count and four selected collection-reference DELETE variants are suppressed; item/cast/count/action/reference neighbors remain. Beta's obsolete directory rollout GET is a reviewed removed duplicate, not a fabricated root relocation; its independent old/current Identity.SignIns policies lineage stays untouched. Structural template/contact/cast naming needs no redundant override. The beta setting entity keeps its source-defined rename.QueryIdand exact native@idbinding; no oldIdalias. Authored configuration stays shared/profile-neutral, while tests propagate the separate runtime profile with derived data on/off. Ignore every profile-local README andsrc/readme.graph.mddirective. Aliases/transforms and schema/response changes remain deferred. No unrelated generator, Authentication, runtime, spec, optional-query, or collection-naming changes.powershell-v3target6475f3f5beb4908d39ea356db32bf1e0fd3273cb. Preserve original migration and generation history, including separate combined Kiota-client + cmdlet/project/lock commits for each profile. Final correction:9cd2c58c28; v1.0 generation:1a0bbcd84d0a555645079975238419b2ed1216a3; beta generation:564e683a88b2e66e54d3cab90709cdf08eb07764. Latest Kiota clients/locks regenerated byte-identically; the PATCH source deltas are generated, not hand-edited. There are no excluded compatible profiles.Validation on the final source
dotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --filter "FullyQualifiedName~DirectoryManagementDirectiveMigrationTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~NamingTests|FullyQualifiedName~RequiredQueryTests" --verbosity quiet --nologo --logger "trx;LogFileName=targeted.trx" --results-directory <EvidenceRoot>pwsh -NoProfile -File .\tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module Identity.DirectoryManagement -FailOnUnresolved -OutputPath <EvidenceRoot>\strict-inventory.jsonpwsh -NoProfile -NonInteractive -File <CoordinatorFiles>\Invoke-QueuedModuleBuild.ps1 -RepoRoot <Worktree> -Module Identity.DirectoryManagement -ApiVersion v1.0 -Configuration Releasepwsh -NoProfile -NonInteractive -File <CoordinatorFiles>\Invoke-QueuedModuleBuild.ps1 -RepoRoot <Worktree> -Module Identity.DirectoryManagement -ApiVersion beta -Configuration Releasepwsh -NoProfile -NonInteractive -File <EvidenceRoot>\Confirm-DirectoryManagementCompiled.ps1 -Profile <v1.0|beta>pwsh -NoProfile -NonInteractive -File <MemoryEvidenceRoot>\Invoke-Runtime.ps1 -Profile <v1.0|beta> -Environment <Global|USGov>Connect-MgGraph+GraphHttpClientFactory, no live Graph/OAuth.pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\Identity.DirectoryManagement\wrapper\<Profile>\Cmdlets -OutLedger <EvidenceRoot>\parity-<Profile>.csvFull runtime proof covers actual Contact and beta DirectorySetting PATCH204: successful, one PATCH, no output, no GET, with the GET configured to return 403; PATCH200: one PATCH, actual typed response. Caller-explicit GET retains its own headers/select/result/error. No
PassThru/readback/refetch flag is introduced. Typed tag POST JSON/arrays and distinct body parameters/results, mandatory QueryId missing/null/empty rejection before HTTP, correctly encoded nonempty Ivan Dyachkov (@id), bodyless reference DELETE/If-Match/custom headers, item/no-query neighbors, WhatIf, genuine declined/accepted Confirm, authenticated Global/USGov routes, stable shared-client BaseAddress, alternating profiles, session invalidation/reconnect/disconnect and assembly identities all passed.Normal adapted Authentication 2.41.2 was imported from the designated source-equivalent package: all 64 SHA256s and physical package SHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EBverified before/after. Bins contain only three owned DLLs, noRequiredAssembliesdependency preloads, and the correct Auth floor/owned Kiota closure. Isolated Kiota 1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, cap 1, and the same four-mutex queue were used process-locally.Exact compatible spec Git blobs: v1.0
00ccf2f5e2fa763d695b78ffc6c78f749b64fecf; beta5ce6586d86ff0f481b43f1dfa3d0cb69149a90c3.Limits: PS7/Core only; Desktop 5.1 unsupported. Offline behavior proof is not tenant/API certification. Raw parity: v1.0: 589/597 matched, 5 mismatches, 3 no-oracle rows (exit 1); beta: 0/963 matched, 951 mismatches, 12 no-oracle rows (exit 1). Beta generated
Mgnames differ from publishedMgBetaoracle prefixes; no normalization or unrelated naming sweep. Existing NU1903 warning for Microsoft.OpenApi.YamlReader 3.7.0 remains. Historical implicit-GET header failures are retained unchanged as user-superseded evidence, not relabeled passes; the final proof uses the merged no-readback contract. #3881 and optional-query tracking #3897 are outside this change.Runtime-isolation probe correction (same PR/head; no production changes): importing Authentication into the genuine-confirmation runspace resets shared GraphSession.DataStore to DiskDataStore. The corrected probe reapplies the existing
Set-MgTestDataStorehelper after the last additional-runspace import and before the first Connect, then reflects and asserts the exact actual typeMicrosoft.Graph.Authentication.Test.Mocks.MockDataStorebefore transport and request-context/reconnect/disconnect/cleanup. Each v1.0 cloud records 34 successful actual-type guards for 14 offline HTTP calls; each beta cloud records 108 guards for 30 calls. All 16/77 runtime cases per cloud, PATCH204/200/explicit GET, QueryId binders/wire, typed bodies, safety and identity checks pass again. The pre-reapply DiskDataStore observation occurs before Connect/HTTP/lifecycle in the corrected run; datastore type alone is not evidence of credential I/O. Prior unguarded runtime reports and their handoff remain unchanged, not relabeled guarded passes.The original FULL build/TRX/source/generation/compiled evidence remains immutable in
post3886-6475-final. Corrected runtime scripts/results and the new canonicalhandoff.jsonare inpost3886-6475-memory-final, referencing the original absolute build/TRX/bin paths and SHA256s.<EvidenceRoot>in the unchanged build/test commands means the former folder;<MemoryEvidenceRoot>means the latter. No Authentication/package/source modification, FULL build, TRX run, Kiota run, generation commit, head change, or new PR was performed for this probe correction. Both folders preserve raw commands/exits, source/Auth/tool hashes, uncapped Git scope and HTTP/body/header/assembly-context evidence. No binaries, logs, packages, or session artifacts are committed.Other links